Удаление собственного комментария #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Zimovchik
requested changes
Aug 5, 2025
rating_api/routes/comment.py
Outdated
| if not has_delete_scope: | ||
| if comment.user_id == None: | ||
| raise ForbiddenAction(Comment) | ||
| elif str(comment.user_id) != str(user.get('id')): |
rating_api/routes/comment.py
Outdated
Comment on lines
312
to
315
| if comment.user_id == None: | ||
| raise ForbiddenAction(Comment) | ||
| elif str(comment.user_id) != str(user.get('id')): | ||
| raise ForbiddenAction(Comment) |
Member
There was a problem hiding this comment.
можно в одно выражение через or
Member
Author
|
@Zimovchik все еще раз протестил после изменений, работает |
Zimovchik
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задание: #134
Изменения
Исправил ошибку с удалением своего комментария. Раньше не имея скоупов админа нельзя было удалить свой комментарий, теперь можно.
Детали реализации
Все протестил при разных случаях, теперь работает. Раньше выбрасывало ошибку 500 из-за ошибки в коде эндпоинта. в структуре Comment нет is_anonymous, поэтому правильная реализация это: comment.user_id == None
Именно из-за этого все падало. А при админских правах ошибки не возникало, так как до этой части кода просто не доходило дело, она используется только обычными пользователями.
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?